Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosine_similarity to hn_mine #1179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daegonYu
Copy link

@daegonYu daegonYu commented Nov 1, 2024

By specifying a range for similarity scores when mining hard negatives, this argument ensures that negative examples fall within a desired difficulty level. This fine-tuned control helps in avoiding extremes—negatives that are either too close or too far in meaning from the query.

This is also explained in the paper (https://arxiv.org/pdf/2405.05374 (Appendix Algorithm 1: Tunable Negative Mining)), and I also used this code to mine hard negatives, and as a result, I was able to create a Reranker model that performed better than the hard negatives mined with the existing code. I would like to contribute to others using this code to create good models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant