fix: visualize 'forecasting script' data source as just a 'forecaster' (

#1211) * fix: visualize 'forecasting script' data source as just a 'forecaster' Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * style(docs): line breaks Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>
FlexMeasures · Oct 15, 2024 · 8427259 · 8427259
1 parent e8444d0
commit 8427259
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/documentation/changelog.rst b/documentation/changelog.rst
@@ -9,7 +9,6 @@ v0.24.0 | October XX, 2024
 
 .. warning:: Upgrading to this version requires running ``flexmeasures db upgrade`` (you can create a backup first with ``flexmeasures db-ops dump``).
 
-
 New features
 -------------
 * The data chart on the asset page splits up its color-coded sensor legend when showing more than 7 sensors, becoming a legend per subplot [see `PR #1176 <https://github.com/FlexMeasures/flexmeasures/pull/1176>`_ and `PR #1193 <https://github.com/FlexMeasures/flexmeasures/pull/1193>`_]
@@ -22,14 +21,14 @@ New features
 
 Infrastructure / Support
 ----------------------
-
 * Speed up status page by choosing for a faster query (only latest belief needed) [see `PR #1142 <https://github.com/FlexMeasures/flexmeasures/pull/1142>`_]
 * For MacOS developers, install HiGHS solver automatically [see `PR #1187 <https://github.com/FlexMeasures/flexmeasures/pull/1187>`_]
 * Add dedicated ``sensors_to_show`` field to asset model and logic to migrate data from parent source(attributes field) [see `PR #1200 <https://github.com/FlexMeasures/flexmeasures/pull/1200>`_]
 
 Bugfixes
 -----------
 * The UI footer now stays at the bottom even on pages with little content [see `PR #1204 <https://github.com/FlexMeasures/flexmeasures/pull/1204>`_]
+* Correct stroke dash (based on source type) for forecasts made by forecasters included in FlexMeasures [see `PR #1211 <https://www.github.com/FlexMeasures/flexmeasures/pull/1211>`_]
 
 
 v0.23.0 | September 18, 2024
@@ -75,6 +74,7 @@ Bugfixes
 * Fix issue with account creation failing when the --logo-url flag is omitted. [see related PRs `PR #1167 <https://github.com/FlexMeasures/flexmeasures/pull/1167>`_ and `PR #1145 <https://github.com/FlexMeasures/flexmeasures/pull/1145>`_]
 * Fix ordering of audit logs (asset, account) and job list on status page [see PR `PR #1179 <https://github.com/FlexMeasures/flexmeasures/pull/1179>_` and `PR #1183 <https://github.com/FlexMeasures/flexmeasures/pull/1183>`_]
 
+
 v0.22.0 | June 29, 2024
 ============================
 

diff --git a/flexmeasures/data/models/data_sources.py b/flexmeasures/data/models/data_sources.py
@@ -344,11 +344,17 @@ def to_dict(self) -> dict:
         model_incl_version = self.model if self.model else ""
         if self.model and self.version:
             model_incl_version += f" (v{self.version})"
+        if "forecast" in self.type.lower():
+            _type = "forecaster"  # e.g. 'forecaster' or 'forecasting script'
+        elif "schedul" in self.type.lower():  # e.g. 'scheduler' or 'scheduling script'
+            _type = "scheduler"
+        else:
+            _type = "other"
         return dict(
             id=self.id,
             name=self.name,
             model=model_incl_version,
-            type=self.type if self.type in ("forecaster", "scheduler") else "other",
+            type=_type,
             description=self.description,
         )