-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict Audit Log Button Visibility #1228
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
@nhoening the changelog entry for this, should it be a bugfix or feat? |
Bugfix, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check other templates where these buttons also exist, as well:
- ui/templates/crud/account.html
I noticed that ui/templates/crud/user.html could have the button, but doesn't yet. Should we add it there?
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
I think it makes sense to add it to that page as well. |
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small naming change.
We should make sure this is tested though, at least manually.
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Conditionally display audit log buttons based on user permissions
Look & Feel
As a Staff User
As an Admin User
How to test
Further Improvements
None
Related Items
This PR closes: #1222