Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow group on hatch. #249

Open
wants to merge 6 commits into
base: new-core
Choose a base branch
from
Open

Conversation

Baviaan
Copy link
Contributor

@Baviaan Baviaan commented Jun 19, 2019

Looks like I inadvertently closed #248 when I renamed my branch.

I suggested 1s leeway on the group command before throwing an invalid time error because a raid report does not store the given hatch time precisely:

# Program flow for !raid 5 here 18:00

stamp = await converter.convert(ctx, gym_split[-1]) # 18:00:00
dt = stamp - time.time()                            # 00:29:55 = 18:00:00 - 17:30:05
endtime = dt/60                                     # 00:29:55 /60
hatch = time.time() + 60*endtime                    # 18:00:00.1 = 17:30:05.1 + 00:29:55 * 60/60
                                                    # !group 18:00 throws an error

@Baviaan
Copy link
Contributor Author

Baviaan commented Jul 10, 2019

Changed the leeway to 1 min and allow 'hatch' as argument for a group time.

@Baviaan
Copy link
Contributor Author

Baviaan commented Sep 28, 2019

Changed it to get the current time once at the start of the function so there is no inconsistencies in what the 'current time' is between the five time() calls.

@Baviaan
Copy link
Contributor Author

Baviaan commented Dec 1, 2020

Updated to resolve the conflict with master that has been introduced the past year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant