Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshoter 1.0.0 #175

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Screenshoter 1.0.0 #175

merged 2 commits into from
Aug 21, 2023

Conversation

cjmaxik
Copy link
Contributor

@cjmaxik cjmaxik commented Aug 21, 2023

This small add-on adds a player button and a shortcut to take and download a screenshot of a current stream frame.

SirStendec
SirStendec requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@SirStendec SirStendec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of this add-on.

Please remove the unnecessary addFilter call, though. As commented, it's unnecessary and may only serve to confuse users.

src/screenshoter/index.js Show resolved Hide resolved
src/screenshoter/index.js Outdated Show resolved Hide resolved
src/screenshoter/index.js Outdated Show resolved Hide resolved
@cjmaxik
Resolving issues
ab4f473 
- Remove redundant `isValidShortcut` function
- Check if `video` is a stream or not (we cannot screenshot clips yet)
- Style fixesScreenshoter 1.0.0
@SirStendec SirStendec merged commit d5b132f into FrankerFaceZ:master Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirStendec SirStendec SirStendec requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjmaxik @SirStendec