Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(screenshotter): add setting to save as file & copy #227

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

ConnorDoesDev
Copy link
Contributor

No description provided.

Copy link
Collaborator

@SirStendec SirStendec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not satisfied with how you've implemented the settings here.

src/screenshoter/index.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ConnorDoesDev ConnorDoesDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with your suggestion of having seperate settings, thanks!

src/screenshoter/index.js Outdated Show resolved Hide resolved
@ConnorDoesDev
Copy link
Contributor Author

Little friday bump ^

@SirStendec
Copy link
Collaborator

Apologies, I didn't want to accept this until I fixed the issues with the CI system.

That said, I noticed that you haven't updated the manifest to bump the add-on's version number. Please do so.

@ConnorDoesDev
Copy link
Contributor Author

I've bumped it to 1.2.1 since this isn't a major update, and not a patch but rather a minor update
I've also added myself as one of the authors (the original author can't be found anywhere though 🤔)

@SirStendec SirStendec merged commit baf8abb into FrankerFaceZ:master Aug 12, 2024
1 check passed
@ConnorDoesDev ConnorDoesDev deleted the patch-1 branch August 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants