Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update t.test test expectations for new error in R >= 4.4 #89

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

slager
Copy link
Contributor

@slager slager commented Aug 12, 2024

In R version >= 4.4, an error is now thrown if the paired argument is used in a call to the t.test.formula method. The error happens if the paired argument is used at all, i.e. it doesn't matter if it's TRUE or FALSE.

See here:

The formula methods for t.test() and wilcox.test() now catch when paired is passed, addressing PR#14359; use Pair(x1, x2) ~ 1 for a paired test.

Several such calls took place in setting up the testthat expectations for VISCfunctions, which were leading to failed unit tests on R 4.4.1, and I believe I've fixed those here.

@slager slager mentioned this pull request Aug 12, 2024
@slager
Copy link
Contributor Author

slager commented Sep 4, 2024

Merged changes in develop from #91 into this PR branch, and now all the CI checks are passing.

Copy link
Contributor

@mayerbry mayerbry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this. I did a little extra investigation and it doesn't seem possible to produce the error through specification of two_samp_cont_test itself, which is a good thing

@slager slager merged commit bd9c7fe into develop Sep 4, 2024
6 checks passed
@slager slager deleted the t branch September 4, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants