Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up invalid ORCID placeholder generated by usethis that throws error on R version 4.5.x #248

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Bug fixes
* Provide default CRAN mirror if missing in install_load_cran_packages(), e.g., in a child R session during knitting. Fixes 'trying to use CRAN without setting a mirror' error (#218)
* Update template.tex so that flextable package can be used to create tables in PDF documents (#226)
* Clean up invalid ORCID placeholder generated by usethis 3.0.0 that threw error on R version 4.5.x (#248)

Other improvements
* create_visc_project() now discards README.Rmd after knitting template to README.md (#223)
Expand Down
10 changes: 9 additions & 1 deletion R/create_visc_project.R
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,15 @@ create_visc_project <- function(path, interactive = TRUE){
usethis::create_package(
path = path,
rstudio = TRUE,
open = interactive
open = interactive,
# fields override for usethis 3.0.0 ORCID placeholder that errored in R 4.5
# https://github.com/r-lib/usethis/issues/2059
fields = list(
`Authors@R` = paste0(
"person(\"First\", \"Last\", email = \"first.last",
"@example.com\", role = c(\"aut\", \"cre\"))"
)
)
)

# must set active project otherwise it is <no active project>
Expand Down
1 change: 0 additions & 1 deletion man/use_visc_methods.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading