Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added todo comments for clarification #15
added todo comments for clarification #15
Changes from 4 commits
1507cb1
a4e7767
8aeeec1
caa4688
daf4446
0a2b0c1
12ef572
883734b
5781565
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sobrien29 this might be a good question to address with Alice and the broader team; e.g. how many timepoints are required for minimum functionality, will we require the pgPEN library, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree with the idea let's develop this for the Berger lab first and then we can try to expand this package's flexibility as we move along. But totally, this is probably a bigger and ongoing discussion amongst the team!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At minimum we need a T0 (or plasmid) and a later timepoint (actual timing is dependent mainly on cell growth kinetics). Intermediate timepoints can be included for a time-based analysis if wanted and I believe the test data includes one intermediate timepoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sobrien29 How would you describe this to a user in this context? What is a T0? That means just the first time point at 0 days? Do you have a paper we can link to that give people the basics of CRISPR screens?