-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
89 husky install deprecated #90
base: master
Are you sure you want to change the base?
Conversation
husky install is deprecated, the documentation also said to use postinstall instead of prepare because yarn does not support it. Updated the README.md to mirror the script change as well. closes #89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
just a small suggestion and a question.
@@ -15,7 +15,7 @@ To view our site and see your contributions, visit <https://fcc-seoul.fly.dev> | |||
- Husky setup (only once) | |||
|
|||
```bash | |||
yarn prepare | |||
yarn run postinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need run
here, but not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not opposed to it, but can I know the reason for removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously
Currently