Yanic update #105
Open
Yanic update #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like copying static files instead of building them from variables |
|
@mortzu I understand that static config files are not nice; but the Ansible variables for the configuration would probably be as long as the yanic.conf.ffmapserver itself, and the yanic.conf template file itself would be again as long. So there would not be much improvement, while complexity would be added. That's why I think static config files are better in this case. |
|
Please rebase (before i start a review ) - to much code / changes |
This was also changed on the actual server in 2016, so it's probably necessary.
This uses the current config file taken from actual ffmap server, except that the (unused) influxdb2 access token was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the yanic role to the current content of the ffmap server.
To simplify the Ansible role, this now uses a static yanic.conf file for each server, rather than creating the config file from Ansible variables. Only the secret parts are still taken from variables which are defined in the vault file.