Migrate to systemd timers #97
Conversation
corny
force-pushed
the
timers
branch
3 times, most recently
from
be7cceb
to
3e7b792
Compare
roles/timer/tasks/main.yml
Outdated
| register: template_result | ||
|
|
||
| - name: Reload systemd | ||
| command: systemctl daemon-reload |
There was a problem hiding this comment.
please use the ansible module for this:
https://docs.ansible.com/ansible/latest/modules/systemd_module.html#parameter-daemon_reload
There was a problem hiding this comment.
@mortzu you asked for ... this task is unnecessary
corny
force-pushed
the
timers
branch
6 times, most recently
from
9e5e567
to
558722b
Compare
roles/timer/tasks/main.yml
Outdated
| register: template_result | ||
|
|
||
| - name: Reload systemd | ||
| command: systemctl daemon-reload |
roles/timer/tasks/main.yml
Outdated
| with_items: | ||
| - service | ||
| - timer | ||
| register: template_result |
There was a problem hiding this comment.
| register: template_result | |
| notify: reload systemd |
and something in roles/timer/handlers/main.yml
roles/timer/tasks/main.yml
Outdated
| - name: Enable and start timer | ||
| service: | ||
| name: "{{ timer_name }}.timer" | ||
| daemon_reload: yes |
There was a problem hiding this comment.
Here is already a daemon_reload ...
| command: systemctl daemon-reload | ||
| when: template_result.changed | ||
|
|
||
| - name: Enable and start timer |
There was a problem hiding this comment.
Should we always enable and start the Timer?
Maybe a deployment of generic timers would be nice - ala:
update-fastd-blacklist@.service where the variable %I could be the {{ site_code }}
|
Unnötige |
UPS sorry, github war verwirrend - nope, kannst von mir aus nach ein test mergen |
Timers are easier to debug and give more control about the scheduling.
Timers are easier to debug and give more control about the scheduling.
TODO: Needs to be tested!