refactor: retire the LSP system - #2429
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lsp_*peer-host invokes instead of silently falling backValidation
cargo test -p bitfun-cli retired_lsp_commands(2 passed)cargo check -p bitfun-sdk-host-app -p bitfun-serverpnpm run check:core-boundaries(rerun after rebase)pnpm run capabilities:checkpnpm run capabilities:test(9 passed)pnpm run website:test(6 passed)pnpm run website:build(22 feature guides + 16 settings guides)git diff --check origin/1.0.0-explore...HEADDesktop test sources compiled, but launching the local test binary was blocked by a rebuildable DLL artifact issue (
STATUS_ENTRYPOINT_NOT_FOUND). The regular Web type-check was likewise blocked by an incomplete localnode_modulesinstallation; these are local build-product issues rather than source defects.E2E was intentionally not run, as requested. Remote workspace/control/Peer Device/Detached Dispatch E2E scenarios were not exercised; legacy peer-host retirement behavior is covered by the focused CLI tests above.
Submission hygiene
Untracked design/QA documents,
.pnpm-store/, andNUL*intermediates were excluded. The only added file ispackages/dsh-acp/tests/tool-view.spec.ts.