Windows GafferArnold tests #5860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows won't be able to delete the temporary file in `tearDown()` if it is still open.
Calling `kick` from Gaffer currently doesn't work for at least two reasons: 1. We create an Arnold plugin called `Gaffer.dll`. When calling `kick`, it will attempt to load this plugin. `kick` seems to think it should use the `Gaffer.dll` we build for core Gaffer - renaming the plugin fixes the loading problem. 2. Even with that fix, there's an error `IECoreGL::init::DllMain : Failed to register window class`. I'm not sure what the cause of this error is yet.
- Windows doesn't allow read-only directories, so we split that part out of `testLogDirectoryCreation` into a separate test we can skip. - Something is holding the Arnold log open even after destroying the renderer. This prevents Windows from cleaning up without errors.
- Use "gaffer.cmd". We don't use `str( Gaffer.executablePath() )` to avoid the dependency on the `Gaffer` module. - Arnold returns `atStringStruct` instead of `atStringReturn`. - Don't attempt to run `kick` which isn't working on Windows currently.
When setting outputs directly with `addOutput`, we need to do the conversion to `/`-based paths because there is no string plug to do the conversion for us.
Without this, on Windows `GafferArnoldUITest` errors with a long string of `ERROR : Qt : QEventDispatcherWin32::wakeUp: Failed to post a message (Not enough quota is available to process this command.)`
On Windows, the script to build the scene in `testUserDefaultMetadata()` was failing to execute correctly, resulting in no scene being written. I don't know exactly the cause, but writing out the script to a temporary file works around whatever differences there are in passing a multi-line command to Python.
`GafferArnold` on Windows does not seem to reliably fill the id or depth buffers used by `SceneGadget::objectAt()` ( via `OutputBuffer::idAt` ). In order to get the vast majority of GafferArnold tests activated, we skip these for now.
Automated testing of automatic light groups fails, whereas the same tests done manually give the expected results. In order to get the vast majority of GafferArnold tests activated, we skip this test for now.
ericmehl
force-pushed
the
Windows-GafferArnoldTest
branch
from
995b1db
to
a48b8f6
Compare
ericmehl
force-pushed
the
Windows-GafferArnoldTest
branch
from
cd0a9c0
to
876d23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables running tests for Arnold on Windows CI :
GafferArnoldTest,GafferArnoldUITestandIECoreArnoldTest.There are a few that I haven't figured out how to fix to get them passing - those have been marked with
skipIfdecorators in order to get all the other tests exercising on Windows.Checklist