Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetadataOverlay : Add new node for overlaying metadata on image #6092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnhaddon
Copy link
Member

Just a simple little node implemented as a box and exported via ExtensionAlgo. Hopefully this is flexible enough to cover most cases, and is instructive enough to provide an example for folks who want to customise something more heavily themselves.

@murraystevenson
Copy link
Contributor

Nice one! This does look very useful for folks just wanting to put some metadata on-screen without resorting to rolling their own expression setup.

One thing I wonder about is the behaviour when missing metadata keys are specified in Standard mode. At present we get a fairly user-unfriendly error from line 38 of the expression trying to remove the invalid key from availableKeys. Should we ignore missing keys in this situation, have a mode to do so, and/or improve the error message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

2 participants