IECoreCycles : Use intrusive_ptr where appropriate
#6098
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All these functions allocate and return new data, so should assign to a `Ptr` to take ownership from the word go, and then return a `Ptr` to pass ownership to the caller. As it happened, all the existing callers were assigning the result to a Ptr anyway, but this did leave open a window during which an exception would result in a memory leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these functions allocate and return new data, so should assign to a
Ptrto take ownership from the word go, and then return aPtrto pass ownership to the caller. As it happened, all the existing callers were assigning the result to a Ptr anyway, but this did leave open a window during which an exception would result in a memory leak.