Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comparison ops #245

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nstarman
Copy link
Contributor

Fixes #244

@nstarman nstarman added this to the v0.19.0 milestone Oct 22, 2024
@nstarman nstarman requested a review from adrn October 22, 2024 15:26
@nstarman
Copy link
Contributor Author

The block_until_ready error appears to be unrelated. But it would be good to solve. I'm not getting it on my machine.

@nstarman
Copy link
Contributor Author

Apparently it is related #246 isn't triggering it.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
Copy link
Contributor Author

Found it. It's the new version of equinox. 0.11.8.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (70adbef) to head (366b453).

Files with missing lines Patch % Lines
src/unxt/_src/quantity/register_primitives.py 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   95.75%   96.19%   +0.44%     
==========================================
  Files          40       40              
  Lines        1483     1421      -62     
==========================================
- Hits         1420     1367      -53     
+ Misses         63       54       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman
Copy link
Contributor Author

@adrn should be ready to review

@nstarman
Copy link
Contributor Author

I actually need to cut a release. This can be a bugfix release to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison with quantity not working
1 participant