Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make axes in plots log scale #7

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

tegonzalo
Copy link

This has been requested a few times from gambit folk in pippi plots, so I'm submitting this PR with my own hacks so that everyone has it.

@patscott patscott self-requested a review June 30, 2021 05:31
Fixed conflicts:
	example/example.pip
	example/example_diver.pip
	modified:   ../pippi
	modified:   ../pippi_colours.py
	modified:   ../pippi_parse.py
	modified:   ../pippi_plot.py
	modified:   ../pippi_read.py
	modified:   ../pippi_script.py
	modified:   ../pippi_utils.py
Copy link
Member

@patscott patscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Tomas. I made some additional tweaks for Python compatibility (both 3 and 2.7) on my installation, but it generally looks quite good.

However, I have the problem that when I run the example, ctioga2 hangs on trying to make the 2D plots. This doesn't happen on the master, and doesn't happen on this fork either if you don't use the log axis feature. I recall having something like this problem with ctioga2 at times way back in 2011/12 when I first wrote pippi. I am amazed that it is still an issue today on Ubuntu 20.04 (with stock ctioga 0.14.1, much later than what I was using in the past). This issue was why I included a home-brewed log axis option in pippi in the first place, rather than using ctioga2's built-in option. So I am not really sure what to do at this stage; any ideas?

@tegonzalo
Copy link
Author

Ah ok. I have not seen this happening in any of my machines, but I heard Ankit had issues with it too. I did some work on creating some custom ticks and labels for log scale for the DMEFT project, because the ctioga default looked terrible sometimes. I could polish that and then make it the default in the case of log scale and abandon the default ctioga log settings. After all, the only thing missing from your home-brewed log axes were ticks and labels, at least that I can think of, so that should do it. What do you think?

@patscott
Copy link
Member

patscott commented Jul 1, 2021

great idea, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants