Update handling for EOF,ErrClosedPipe to hard return #9
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @amilstead. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
CLA submitted. Sorry that wasn't done ahead of time. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amilstead, hopkiw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@amilstead Thanks for the PR, looks good. Can you update the tests for this change? |
Sure! Will work on that sometime this week. Thanks! |
|
Tests added-- I am by no means a go-expert, so please lmk if these tests are garbage or should be done differently. |
|
@hopkiw just nudging here. Anything else I need to do? |
| @@ -290,3 +290,71 @@ func TestAptMethodRunFail(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Test the case where the remote-end closes its pipe: | |||
| func TestAptMethodRunReaderEOF(t *testing.T) { | |||
There was a problem hiding this comment.
Apologies for delays. I checked out this code and ran the tests, and as a first sanity test, I removed your EOF handling change, and these tests still pass. Can you add a test that exercises and breaks the pipe in a way that should be handled, to confirm your code is correctly handling it?
There was a problem hiding this comment.
I will see what I can come up with, sure. That said, this particular change I'm not positive has such a test. The major difference here is breaking out of an infinite loop in the event that these pipe-related errors propagate. So my knee-jerk is that there isn't an analogous negative test, or at least not a good one that doesn't involve too much ugly mirror and/or doing something like spinning threads and waits, which will be inherently brittle.
|
Hi sorry, I just really don't have time to work on this. If someone else wants to pick up this PR and finish, please do. All I can say is that this "works for me". |
After looking at cloudflare's apt-transport that behaves very similarly it seems like a hard return is the right way to handle
EOFandErrClosedPipeerrors coming from the reader.See here: https://github.com/cloudflare/apt-transport-cloudflared/blob/8fd3a7c4318a39b24d08b0fb62ed9983e1558aea/apt/method.go#L82-L85
Somewhat related; I needed this change plus a different binary name (see here) to get this transport to work under reprepro.