Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Exceptions completion #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faust64
Copy link

@faust64 faust64 commented Jan 24, 2020

The Kubernetes API server may throw exceptions that would not be caught by that plugin.

A concrete sample would be to deploy FUSE on OpenShift, with NetworkPolicies.
If said NetworkPolicies prevent the k8s API server to communicate with some Jolokia service, then we would find a trace in the API server logs.
That traces starts with a goroutine <int> ..., with no prior mention of a "panic" or "http: panic".

The Kubernetes API server may throw exceptions that would not be caught by that plugin.

A concrete sample would be to deploy FUSE on OpenShift, with NetworkPolicies.
If said NetworkPolicies prevent the k8s API server to communicate with some Jolokia service, then we would find a trace in the API server logs.
That traces starts with a `goroutine <int> ...`, with no prior mention of a "panic" or "http: panic".
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@faust64
Copy link
Author

faust64 commented Jan 24, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link

@StevenYCChou StevenYCChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faust64 Thanks for the contribution!

Can you provide a snippet of sample logs as you described in your comment? Once you have the sample logs, you can use it to write a test for the rule you added.

Check PR #49 as a sample PR to learn how to add a testcase for exception from Golang.

@StevenYCChou StevenYCChou self-assigned this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants