Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup references to old config #2429

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Cleanup references to old config #2429

merged 1 commit into from
Oct 22, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (1e9ef9b) to head (e0109fb).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cmd/root.go 33.33% 2 Missing ⚠️
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2429      +/-   ##
==========================================
- Coverage   78.45%   77.76%   -0.70%     
==========================================
  Files         108      104       -4     
  Lines       15907    15153     -754     
==========================================
- Hits        12480    11783     -697     
+ Misses       2918     2875      -43     
+ Partials      509      495      -14     
Flag Coverage Δ
unittests 77.76% <25.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore force-pushed the config-cleanup branch 2 times, most recently from eb7dcdd to 8c2878e Compare October 11, 2024 18:21
@kislaykishore kislaykishore marked this pull request as ready for review October 11, 2024 18:21
@kislaykishore kislaykishore requested review from Tulsishah and a team as code owners October 11, 2024 18:21
@kislaykishore kislaykishore requested review from a team October 11, 2024 18:21
@kislaykishore kislaykishore merged commit e66792c into master Oct 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants