Make control client retry able in e2e tests #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
+ Coverage 78.09% 78.46% +0.37%
==========================================
Files 108 108
Lines 11860 15905 +4045
==========================================
+ Hits 9262 12480 +3218
- Misses 2088 2916 +828
+ Partials 510 509 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team,
gargnitingoogle and
BrennaEpp
and removed request for
a team and
gargnitingoogle
charith87
reviewed
Oct 17, 2024
charith87
reviewed
Oct 17, 2024
charith87
reviewed
Oct 17, 2024
charith87
reviewed
Oct 18, 2024
charith87
reviewed
Oct 18, 2024
charith87
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make control client retry able in e2e tests to avoid failures in case of server errors.
Link to the issue in case of a bug fix.
NA
Testing details