Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to retry for stalled read request #2612

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Oct 21, 2024

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@raj-prince raj-prince added the execute-integration-tests Run only integration tests label Oct 21, 2024
@raj-prince raj-prince marked this pull request as ready for review October 21, 2024 14:46
@raj-prince raj-prince requested a review from a team as a code owner October 21, 2024 14:46
@kislaykishore kislaykishore requested review from a team, kislaykishore and tritone and removed request for a team and kislaykishore October 21, 2024 14:46
@raj-prince raj-prince added automerge Summon MOG for automerging and removed automerge Summon MOG for automerging labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (8464802) to head (cf72660).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/storage/storage_handle.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2612      +/-   ##
==========================================
+ Coverage   78.39%   78.44%   +0.05%     
==========================================
  Files         108      108              
  Lines       15907    15933      +26     
==========================================
+ Hits        12470    12499      +29     
+ Misses       2926     2922       -4     
- Partials      511      512       +1     
Flag Coverage Δ
unittests 78.44% <76.92%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/legacy_main.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore requested a review from a team October 22, 2024 05:03
@raj-prince raj-prince added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Oct 22, 2024
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
internal/storage/storage_handle_test.go Show resolved Hide resolved
internal/storage/storage_handle_test.go Show resolved Hide resolved
internal/storage/storage_handle_test.go Show resolved Hide resolved
internal/storage/storage_handle_test.go Show resolved Hide resolved
internal/storage/storageutil/test_util.go Show resolved Hide resolved
@raj-prince raj-prince added automerge Summon MOG for automerging and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Summon MOG for automerging execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants