Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonsensical code. #2613

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Remove nonsensical code. #2613

merged 1 commit into from
Oct 22, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner October 22, 2024 05:17
@kislaykishore kislaykishore requested review from a team, gargnitingoogle and BrennaEpp and removed request for a team and gargnitingoogle October 22, 2024 05:18
@kislaykishore kislaykishore enabled auto-merge (squash) October 22, 2024 05:18
Copy link
Collaborator

@gargnitingoogle gargnitingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kislaykishore kislaykishore merged commit 1e60635 into master Oct 22, 2024
17 checks passed
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (1e9ef9b) to head (344d398).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
+ Coverage   78.45%   78.50%   +0.04%     
==========================================
  Files         108      108              
  Lines       15907    15907              
==========================================
+ Hits        12480    12487       +7     
+ Misses       2918     2912       -6     
+ Partials      509      508       -1     
Flag Coverage Δ
unittests 78.50% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore deleted the minor-cleanup branch October 22, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants