Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New samples: Natural Language 2 SQL guide. #1297

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

ganochenkodg
Copy link
Contributor

Code and tf for the NL2SQL guide

Copy link

snippet-bot bot commented May 23, 2024

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ganochenkodg ganochenkodg marked this pull request as draft May 23, 2024 15:34
@ganochenkodg ganochenkodg marked this pull request as ready for review May 29, 2024 12:31
@bourgeoisor
Copy link
Member

@ganochenkodg could you add a workflow that dry-tests the TF directories? (terraform validate). You can find some existing examples in the .github/workflows directory.

https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/.github/CONTRIBUTING.md#samples-requirements

And feel free to ping me when the PR is stable and ready for review :)

@ganochenkodg
Copy link
Contributor Author

Sure, i will

@ganochenkodg
Copy link
Contributor Author

Added

@bourgeoisor bourgeoisor changed the title Natural Language 2 SQL guide. New samples: Natural Language 2 SQL guide. Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants