Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "sample-public-image-"prefixed tags to images #1473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add "sample-public-image-"prefixed tags to images #1473

wants to merge 1 commit into from

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Oct 1, 2024 •
edited by iennae
Loading

Description

  • Please see comment in Google-internal bug b/370252964#comment2.

Tasks

  • Merge this pull-request for me once it is approved.

@iennae
Copy link

iennae commented Oct 9, 2024

we can use b links but guidance is not make an active link

iennae
iennae approved these changes Oct 9, 2024
View reviewed changes
Copy link

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for doing this critical work!

@NimJay
Copy link
Collaborator Author

NimJay commented Oct 22, 2024

Thanks for much for reviewing this, Jennifer!

We'll likely close this pull-request in favour of b/374760962. But I'll wait until b/374760962 is resolved.
Looks like there's a merge conflict I'd have to resolve anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

@theemadnes theemadnes Awaiting requested review from theemadnes theemadnes is a code owner

@aburhan aburhan Awaiting requested review from aburhan aburhan is a code owner

@alizaidis alizaidis Awaiting requested review from alizaidis alizaidis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @iennae