Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets and schema updates #15

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Datasets and schema updates #15

wants to merge 12 commits into from

Conversation

max-ostapenko
Copy link
Collaborator

@max-ostapenko max-ostapenko commented Sep 19, 2024

  1. Stabilisation of all schema tables
    Implemented in Stable all.pages dataform#8 and Stable all.requests dataform#5
  • Pruned summary description
  • Splitting custom_metrics
  • Structured data columns type changed from STRING to JSON

@max-ostapenko max-ostapenko changed the title Pruned summary description Datasets and schema updates Sep 30, 2024
@max-ostapenko max-ostapenko marked this pull request as ready for review September 30, 2024 16:20
@rviscomi rviscomi marked this pull request as draft October 7, 2024 13:46
@rviscomi
Copy link
Member

rviscomi commented Oct 7, 2024

Moving back to draft until we've finalized the schema changes

Comment on lines +210 to +252
"_minify_savings": -1,
"_minify_total": -1,
"_optimization_checked": 1,
"_origin_dns": {
"cname": [],
"https": [],
"mx": ["0 ."],
"ns": [
"a.iana-servers.net.",
"b.iana-servers.net."
],
"soa": [
"ns.icann.org. noc.dns.icann.org. 2024081420 7200 3600 1209600 3600"
],
"svcb": [],
"txt": [
"\"v=spf1 -all\"",
"\"wgyf8z8cgvm2qmxpnbnldrcltvk4xqfn\""
]
},
"_osPlatform": "x86_64 x86_64",
"_osVersion": "Linux 6.8.0-1014-gcp",
"_os_version": "Linux 6.8.0-1014-gcp",
"_render": 400,
"_renderBlockingCSS": 0,
"_renderBlockingJS": 0,
"_requests": 2,
"_requestsDoc": 2,
"_requestsFull": 2,
"_responses_200": 1,
"_responses_404": 1,
"_responses_other": 0,
"_result": 99999,
"_run": 1,
"_score_cache": -1,
"_score_cdn": 100,
"_score_combine": -1,
"_score_compress": -1,
"_score_cookies": -1,
"_score_etags": -1,
"_score_gzip": 100,
"_score_keep-alive": 100,
"_score_minify": -1,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_minify_savings": -1,
"_minify_total": -1,
"_optimization_checked": 1,
"_origin_dns": {
"cname": [],
"https": [],
"mx": ["0 ."],
"ns": [
"a.iana-servers.net.",
"b.iana-servers.net."
],
"soa": [
"ns.icann.org. noc.dns.icann.org. 2024081420 7200 3600 1209600 3600"
],
"svcb": [],
"txt": [
"\"v=spf1 -all\"",
"\"wgyf8z8cgvm2qmxpnbnldrcltvk4xqfn\""
]
},
"_osPlatform": "x86_64 x86_64",
"_osVersion": "Linux 6.8.0-1014-gcp",
"_os_version": "Linux 6.8.0-1014-gcp",
"_render": 400,
"_renderBlockingCSS": 0,
"_renderBlockingJS": 0,
"_requests": 2,
"_requestsDoc": 2,
"_requestsFull": 2,
"_responses_200": 1,
"_responses_404": 1,
"_responses_other": 0,
"_result": 99999,
"_run": 1,
"_score_cache": -1,
"_score_cdn": 100,
"_score_combine": -1,
"_score_compress": -1,
"_score_cookies": -1,
"_score_etags": -1,
"_score_gzip": 100,
"_score_keep-alive": 100,
"_score_minify": -1,
"_optimization_checked": 1,
"_origin_dns": {
"cname": [],
"https": [],
"mx": ["0 ."],
"ns": [
"a.iana-servers.net.",
"b.iana-servers.net."
],
"soa": [
"ns.icann.org. noc.dns.icann.org. 2024081420 7200 3600 1209600 3600"
],
"svcb": [],
"txt": [
"\"v=spf1 -all\"",
"\"wgyf8z8cgvm2qmxpnbnldrcltvk4xqfn\""
]
},
"_osPlatform": "x86_64 x86_64",
"_osVersion": "Linux 6.8.0-1014-gcp",
"_os_version": "Linux 6.8.0-1014-gcp",
"_render": 400,
"_renderBlockingCSS": 0,
"_renderBlockingJS": 0,
"_requests": 2,
"_requestsDoc": 2,
"_requestsFull": 2,
"_responses_200": 1,
"_responses_404": 1,
"_responses_other": 0,
"_result": 99999,
"_run": 1,
"_score_cache": -1,
"_score_cdn": 100,
"_score_compress": -1,
"_score_gzip": 100,
"_score_keep-alive": 100,

Deprecated: https://docs.webpagetest.org/metrics/page-metrics/#optimization-checks%2Fgrades

"_score_minify": -1,
"_score_progressive_jpeg": -1,
"_server_rtt": 0,
"_start_epoch": 1726370501.1809506,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_start_epoch": 1726370501.1809506,

Deprecated: https://docs.webpagetest.org/metrics/page-metrics/#test-information

Comment on lines +44 to +46
"_browserVersion": "128.0.0.0",
"_browser_name": "Chrome",
"_browser_version": "128.0.0.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate: https://docs.webpagetest.org/metrics/page-metrics/#browser-state

Suggested change
"_browserVersion": "128.0.0.0",
"_browser_name": "Chrome",
"_browser_version": "128.0.0.0",
"_browser_name": "Chrome",
"_browser_version": "128.0.0.0",

"_gzip_total": 648,
"_image_savings": 0,
"_image_total": 0,
"_interactivePeriods": [[0, 3452]],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_interactivePeriods": [[0, 3452]],

Deprecated: https://docs.webpagetest.org/metrics/page-metrics/#interactivity-metrics

"_TTFB": 232,
"_TTIMeasurementEnd": 3452,
"_URL": "https://www.example.com/",
"_aft": 0,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"_testUrl": "https://www.example.com/",
"_test_run_time_ms": 5850,
"_tester": "agents-west-1-kl42-10.138.2.146",
"_titleTime": 76,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_titleTime": 76,

Deprecated: https://docs.webpagetest.org/metrics/page-metrics/#visual-metrics

"_final_base_page_request_id": "44714C6F6C72B045136D19CA9894886A",
"_final_url": "https://www.example.com/",
"_firstContentfulPaint": 354,
"_firstMeaningfulPaint": 354,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_firstMeaningfulPaint": 354,

Deprecated: https://docs.webpagetest.org/metrics/page-metrics/#visual-metrics

"_firstContentfulPaint": 354,
"_firstMeaningfulPaint": 354,
"_firstPaint": 314.80000000447035,
"_fullyLoaded": 323,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_fullyLoaded": 323,

Duplicate: https://docs.webpagetest.org/metrics/page-metrics/#technical-page-metrics

Comment on lines +59 to +80
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.domComplete": 320,
"_chromeUserTiming.domContentLoadedEventEnd": 320,
"_chromeUserTiming.domContentLoadedEventStart": 320,
"_chromeUserTiming.domInteractive": 320,
"_chromeUserTiming.domLoading": 285,
"_chromeUserTiming.fetchStart": 48,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.loadEventEnd": 320,
"_chromeUserTiming.loadEventStart": 320,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.navigationStart": 74,
"_chromeUserTiming.responseEnd": 277,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.domComplete": 320,
"_chromeUserTiming.domContentLoadedEventEnd": 320,
"_chromeUserTiming.domContentLoadedEventStart": 320,
"_chromeUserTiming.domInteractive": 320,
"_chromeUserTiming.domLoading": 285,
"_chromeUserTiming.fetchStart": 48,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.loadEventEnd": 320,
"_chromeUserTiming.loadEventStart": 320,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.navigationStart": 74,
"_chromeUserTiming.responseEnd": 277,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.domComplete": 320,
"_chromeUserTiming.domContentLoadedEventEnd": 320,
"_chromeUserTiming.domContentLoadedEventStart": 320,
"_chromeUserTiming.domInteractive": 320,
"_chromeUserTiming.domLoading": 285,
"_chromeUserTiming.fetchStart": 48,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.loadEventEnd": 320,
"_chromeUserTiming.loadEventStart": 320,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.navigationStart": 74,
"_chromeUserTiming.responseEnd": 277,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,

Deprecated: https://docs.webpagetest.org/metrics/page-metrics/#visual-metrics
Duplicates: https://docs.webpagetest.org/metrics/page-metrics/#technical-page-metrics

Suggested change
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.domComplete": 320,
"_chromeUserTiming.domContentLoadedEventEnd": 320,
"_chromeUserTiming.domContentLoadedEventStart": 320,
"_chromeUserTiming.domInteractive": 320,
"_chromeUserTiming.domLoading": 285,
"_chromeUserTiming.fetchStart": 48,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.loadEventEnd": 320,
"_chromeUserTiming.loadEventStart": 320,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.navigationStart": 74,
"_chromeUserTiming.responseEnd": 277,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.domComplete": 320,
"_chromeUserTiming.domContentLoadedEventEnd": 320,
"_chromeUserTiming.domContentLoadedEventStart": 320,
"_chromeUserTiming.domInteractive": 320,
"_chromeUserTiming.domLoading": 285,
"_chromeUserTiming.fetchStart": 48,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.loadEventEnd": 320,
"_chromeUserTiming.loadEventStart": 320,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.navigationStart": 74,
"_chromeUserTiming.responseEnd": 277,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,
Suggested change
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.domComplete": 320,
"_chromeUserTiming.domContentLoadedEventEnd": 320,
"_chromeUserTiming.domContentLoadedEventStart": 320,
"_chromeUserTiming.domInteractive": 320,
"_chromeUserTiming.domLoading": 285,
"_chromeUserTiming.fetchStart": 48,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.loadEventEnd": 320,
"_chromeUserTiming.loadEventStart": 320,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.navigationStart": 74,
"_chromeUserTiming.responseEnd": 277,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,
"_chromeUserTiming.CumulativeLayoutShift": 0,
"_chromeUserTiming.LargestContentfulPaint": 354,
"_chromeUserTiming.LargestTextPaint": 354,
"_chromeUserTiming.TotalLayoutShift": 0,
"_chromeUserTiming.commitNavigationEnd": 285,
"_chromeUserTiming.firstContentfulPaint": 354,
"_chromeUserTiming.firstMeaningfulPaintCandidate": 354,
"_chromeUserTiming.firstPaint": 354,
"_chromeUserTiming.markAsMainFrame": 284,
"_chromeUserTiming.unloadEventEnd": 284,
"_chromeUserTiming.unloadEventStart": 284,

"_renderBlockingJS": 0,
"_requests": 2,
"_requestsDoc": 2,
"_requestsFull": 2,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_requestsFull": 2,

Duplicates: https://docs.webpagetest.org/metrics/page-metrics/#technical-page-metrics

"_domElements": 12,
"_domInteractive": 280,
"_domLoading": 0,
"_domTime": 0,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants