Switch to vendored Lua #1072
Open
Switch to vendored Lua #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3ndrk
added
tools:Debug Tooling
|
@h3ndrk, even though you wrote "does not fix (completely)", github detected it as this PR fixing the linked issue. |
|
Hopefully fixed now 😅 |
|
What is the state with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
When compiling
mluaunvendored, you need to install Lua on your system. Especially under Windoof, this can be painful, therefore we want to switch to a vendored version.Does not heilmachen #1071 completely because we still need further fixes because we are still using symlinks which are not supported under Windoof.
ToDo / Known Issues
It's perfect
Ideas for Next Iterations (Not This PR)
It's perfect
How to Test
Check that Twix compiles under Windoof