WideStance Left and right #1208
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schluis
reviewed
Jul 15, 2024
Comment on lines
+75
to
+92
| match ( | ||
| (-wide_stance_parameters.action_radius..=wide_stance_parameters.action_radius) | ||
| .contains(&horizontal_distance_to_intersection), | ||
| (wide_stance_parameters.action_radius..wide_stance_parameters.action_radius_left) | ||
| .contains(&horizontal_distance_to_intersection), | ||
| (-wide_stance_parameters.action_radius_left..-wide_stance_parameters.action_radius) | ||
| .contains(&horizontal_distance_to_intersection), | ||
| ) { | ||
| (true, _, _) => Some(MotionCommand::WideStance { | ||
| direction: JumpDirection::Center, | ||
| }), | ||
| (false, true, _) => Some(MotionCommand::WideStance { | ||
| direction: JumpDirection::Left, | ||
| }), | ||
| (false, _, true) => Some(MotionCommand::WideStance { | ||
| direction: JumpDirection::Right, | ||
| }), | ||
| (false, false, false) => None, |
There was a problem hiding this comment.
I think a simple if-else statement is completely sufficient. This is basically a glorified if-else. Other opinions? @h3ndrk
There was a problem hiding this comment.
Looks like it, but not sure about the _ in line 89 🤔
There was a problem hiding this comment.
I'm sure. All cases are mutually exclusive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
We want to jump to the right and left whith the WideStance, so we can better catch the blall
Its only for the keeper
Fixes #
ToDo / Known Issues
The Motienfile is in this moment indentical with the WideStance. That is only the .json file
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
You have to kick the ball to the Keeper (playernumber 1) and look