Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source accelerator 27 #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

charlottebrf
Copy link
Member

@charlottebrf charlottebrf commented Nov 28, 2016

Continuation of issue #27.

  1. Resolved conflicts & merged in Master to branch. @eddiejaoude
    screen shot 2016-11-28 at 14 08 22

@charlottebrf
Copy link
Member Author

@eddiejaoude am i ok to merge this PR?

@@ -8,14 +8,15 @@
<ul>
<li><p><b>Join the Hack Brexit fortnightly Wednesday meetup group <a href="https://www.meetup.com/Hack-Brexit/" target="_blank"> here</a></p></b></li>

<li><p><b>Join the Hack Brexit slack group <a href="https://hackbrexit.herokuapp.com/" target="_blank"> here</a></p></b></li>
<li><p><b>Join the Hack Brexit slack group for discussion outside of these in person meetups <a href="https://hackbrexit.herokuapp.com/" target="_blank"> here</a></p></b></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing tags are the wrong way around - check the nesting

Copy link
Member Author

@charlottebrf charlottebrf Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I will check this out & amend

@eddiejaoude
Copy link
Contributor

I have added an inline comment about the closing html tags

@charlottebrf
Copy link
Member Author

Good to be merged @eddiejaoude ?

@eddiejaoude
Copy link
Contributor

It looks good. I would suggest, as <b> is used a lot, it might better to do this in the CSS?

@charlottebrf
Copy link
Member Author

Ok one for me to return to @eddiejaoude :)

@eddiejaoude
Copy link
Contributor

Sure. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants