Fix replica drift convergence test race - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The merged
mainCI exposed a timing race inReplicaControllerTest.followerConvergesThenBacksUpAndRepairsFilesystemDrift.The test waited only until
config.ymlhad been materialized as generation 2, then immediately asserted that the host had reconciled. ProductionapplyRemote()intentionally performs these steps in order:A runner can therefore observe the file between steps 1 and 2, making the test flaky even though the controller behavior is correct.
Fix
Wait for the completed convergence contract instead of the intermediate filesystem write:
config.yml == "two"ReplicaStatus.appliedGeneration == 2Then assert the controller is
READYbefore introducing manual drift.No production code changes.