Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite flag to work with Firefox Nightly #2545

Open
wants to merge 1 commit into
base: py3
Choose a base branch
from

Conversation

earthengine
Copy link

A quick fix for #2544.

Tested in my own computer with doing the same to the UiPasswordPlugin.py file.

@earthengine
Copy link
Author

earthengine commented May 1, 2020

This is not working yet. It fixed in Firefox Nightly but breaks Chrome.

The test result is: if we set "SameSite=None" only, it works in Chrome. But in Firefox Nightly it stops the user from logging in (keep showing the login page). On the other hand, if we set "SameSite=None;secure", Firefox Nightly likes it but Chrome (and Edge) keep showing the login page.

I don't know what the correct solution should be; but I think ZeroNet will have to implement HTTPS and so "SameSite=None;secure" will work on both if using HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants