-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile based on Ubuntu 20.04 #2652
base: py3
Are you sure you want to change the base?
Conversation
I'm not sure about that changes, as I took the original Dockerfile as base. So that's why I have port and other things hardcoded as well as in original. Of course I can put your suggestions, but I think you can commit that directly (I have checked checkbox "Allow edits by maintainers"). |
@JabbaDesilijicTiure @imachug Btw why official docker image/dockerfile https://hub.docker.com/r/nofish/zeronet/dockerfile has same issues? |
That's difficult to implement in Docker, and the other dockerfile in this repo has a hardcoded port as well. Making it random counts as a feature request, but you shouldn't ask the OP to do that. |
Don't underestimate nofish who started this project and don't overestimate me who made a few contributions. We all burn out from time to time, it's okay. |
@JabbaDesilijicTiure @imachug Wow I caught attention to more serious thing than I thought. |
14f2b65
to
bcf447f
Compare
I don't know a lot about China, but heard about Xinjiang re-education camps and The Great Firewall of China, that is also shows China not in good light (I do not justify the Hungary). Anyway the topic will not be fulfilled without mention that Russian Federation also is nazi country, that occupied Ukrainian Crimea and Eastern Donbas and asked support their actions for Hungary government at same time. So It would be hypocrisy to be silent about that from my side when topic goes about despotism. So what your thoughts about that fact? @imachug @JabbaDesilijicTiure anyway I have fixed Dockerfile a bit, updated Ubuntu version and using virtualenv now. |
Ha ha ha, they were nothing without Ukraine in WW2 as well as without USA's Lend-Lease.
Did you heard about Budapest Memorandum and the freezing of borders after World War II? They don't have any legal rights to occupy any territory of Ukraine. I hope the war between China and Russia will happen soon, and you'll feel the things that we in Ukraine feel now protecting our territory against russians nazis. I see real face of supporting terrorism from your side like Russian Federation actions related their neighbors. So after that I can't believe your justification of china camps and russian occupants. We will be on opposite sides. |
Nope, I really disappointed with your position. You're doing the same thing you claim @HelloZeroNet does. But in your case that clearly visible things, unlike situation with Tamas Kocsis. |
lol, turn off russia24 on your tv. Any proofs? Except russian occupation of my country? |
Why you care who run our country? Fuck off.
Why you care where other country goes? You have your China. So fuck off.
Fuck off, you're really terrorist.
It's fake claim, and fake referendum under the russian guns.
It's not you who can decide that, and not another countries even. So fuck off again. |
Fuck off again. And put FSB into your ass before that. NaziJabbaDesilijicTiure. |
I'm very scary. OMG. |
@HelloZeroNet Please merge this PR and lock the discussion. And you guys please stop acting childish. |
@gukandrew I am sorry for the insults. ZeroNet GitHub repository gets invaded by such people from time to time. |
@imachug thank you! I was almost going to close that PR because of that. That's very destructive behavior really will not provide good feedback for the project. |
@imachug sorry, one more thing. Question regarding virtualenv. Do we need that layer? As for me that would be overcomplicating, as we use our container only for ZN and could run as non root user even without virtualenv. |
I think so too, perhaps we're not going to add more Python programs to the container. |
The official Dockerfile on alpine:3.11 doesn't work on Raspberypi OS (RPI4), this works fine
@imachug @HelloZeroNet dropped virtualenv. Now it should build faster. |
@JabbaDesilijicTiure you cannot erase your position as easy as you think. |
@gukandrew Not regarding the topic and discussion about the actual subject, but I think that this Jabba person is just an ordinary troll, whose aim is to insult other people and to enjoy his self-affirmation (I was insulted by him too). Just ignore him and report the tech stuff. |
The official Dockerfile on alpine:3.11 doesn't work on Raspberypi OS (RPI4), this works fine