Automatically build md from Pluto notebooks using PlutoStaticHTML. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pwochner
commented
Oct 4, 2024
pwochner
commented
- Markdown files are built directly from Pluto notebooks.
- Notebooks are executed before conversion => deprecated notebooks will fail.
- Remove obsolete html files.
…lete obsolete html files.
ReubenJ
requested changes
Oct 4, 2024
Comment on lines
142
to
145
| # ╠═╡ disabled = true | ||
| #=╠═╡ | ||
| solution_3 = synth(problem_2, iterator_3) | ||
| ╠═╡ =# |
There was a problem hiding this comment.
Can we use a macro from the Test package to run this and test that an exception is thrown? Then the intended behavior is explicit in both text and code.
There was a problem hiding this comment.
There was a problem hiding this comment.
I added a test to the cell.
ReubenJ
approved these changes
Oct 4, 2024
| #=╠═╡ | ||
| solution_3 = synth(problem_2, iterator_3) | ||
| ╠═╡ =# | ||
| Test.@test_throws HerbSearch.EvaluationError synth(problem_2, iterator_3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.