Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Media Libraries] add bulk delete #194

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IkbelTalebHssan
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan commented Oct 10, 2024

Motivation

This PR includes the implementation of bulk delete functionality via check-boxes, and upon clicking "Delete," the selected media libraries should be removed from the list after confirmation.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (Storybook)
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@IkbelTalebHssan IkbelTalebHssan changed the title feat: add bulk delete feat: [Media Libraries] add bulk delete Oct 10, 2024
@IkbelTalebHssan IkbelTalebHssan removed the request for review from marrouchi October 10, 2024 16:58
Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be attachment blocks or content that are using a given attachment. I wonder how we can handle this.

@IkbelTalebHssan
Copy link
Collaborator Author

There may be attachment blocks or content that are using a given attachment. I wonder how we can handle this.

Thanks for the feedback I'll work on handling this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Add Bulk Delete Functionality to Media Libraries List
2 participants