fix(ui): fix deletion issue for topmost quick reply

[Osho957]

Motivation

This PR fixes an issue with the deletion functionality for the topmost quick reply in the UI. The bug was causing the quick reply at the top of the list not to be removed correctly, potentially affecting the user experience.

Fixes #15

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (Storybook)
• I have added unit tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

ScreenRecording with updated functionality

Screen.Recording.2024-09-16.at.5.27.06.PM.mov

[marrouchi]

Thank you @Osho957

When deleting the first input and submitting the form, a validation message is displayed :

I think we need to pass the "minInput" prop as "0" in the Attachement Message Form. WDYT ?

[marrouchi]

Almost there 👏

[Osho957]

@marrouchi I have gone through the attachment message form and quick replies input code and figured it out that when a quick reply is present then at the time of submission it checks for the validation if it is empty which in my opinion is good
also after checking I found that the top most quick reply was not getting removed so that I fixed adding few screenshots of the testing please verify if its as per expectations.

At the time of uploading

After Submit

Submit Recording without quick reply
https://github.com/user-attachments/assets/3636420d-1216-41fe-8935-26fed0feab54

Submit recording with quick reply
https://github.com/user-attachments/assets/b6d16ca8-e15b-4c1a-8f7f-499c2480f9df

[medtaher123]

@marrouchi can you review this

[medtaher123]

Looks great to me

[Osho957]

@marrouchi @medtaher123 is there anything remaining in this task please do let me know

[yassinedorbozgithub]

LGTM 👍

[yassinedorbozgithub]

Hi @Osho957,
The attachment block form have more than issue :

• ✅ From message section we are not able to delete Quick Replies what is fixed well by this fix(ui): fix deletion issue for topmost quick reply #21
• 🧑‍💻 The API side don't accept attachment_id nullable value so i create an new issue 🐛 [BUG] - unable to submit attachment block edit form #276 to fix the second point separably