Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incomplete blocks removal during delete operation #267

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: incomplete blocks removal during delete operation #267

wants to merge 3 commits into from

Conversation

IkbelTalebHssan
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan commented Oct 24, 2024 •
edited
Loading

Motivation

This PR includes a fix for blocks bulk removal in the visual editor.

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

marrouchi
marrouchi requested changes Oct 25, 2024
View reviewed changes
frontend/src/components/visual-editor/v2/Diagrams.tsx Outdated

return deleteBlock(id, {
for (const blockId of ids) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IkbelTalebHssan

Can we rather implement deleteMany() on the API side ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏
I made some updates can you please check again 🙏

@IkbelTalebHssan IkbelTalebHssan force-pushed the 266-issue-incomplete-block-removal-during-bulk-delete-operation branch from 69e0807 to 3f6fbe0 Compare October 29, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassinedorbozgithub yassinedorbozgithub Awaiting requested review from yassinedorbozgithub

@marrouchi marrouchi Awaiting requested review from marrouchi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - Incomplete Block Removal During Bulk Delete Operation
2 participants
@IkbelTalebHssan @marrouchi