Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attachment-uploader): adding loadingindicator to AttachmentUploader component. #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AuraOfDivinity
Copy link
Contributor

Motivation

This PR adds a loading indicator to the AttachmentUploader component. The added LoadingIcon is reusable and takes in the size & color as props allowing it to be configured as necessary.

Fixes #153

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AuraOfDivinity Awesome !

Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +83 to 85
const [isUploading, setIsUploading] = useState<boolean>(false);
const { toast } = useToast();
const { mutateAsync: uploadAttachment } = useUpload(EntityType.ATTACHMENT, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to add an extra state :

Suggested change
const [isUploading, setIsUploading] = useState<boolean>(false);
const { toast } = useToast();
const { mutateAsync: uploadAttachment } = useUpload(EntityType.ATTACHMENT, {
const { toast } = useToast();
const { mutateAsync: uploadAttachment, isLoading } = useUpload(EntityType.ATTACHMENT, {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Add Loading State for Document Upload in AttachmentUploader Component
2 participants