Skip to content

Commit

Permalink
🐛Fix string concatenation (#57)
Browse files Browse the repository at this point in the history
of the error message introduced in #56
  • Loading branch information
hf-kklein authored Oct 4, 2023
1 parent 60bf56f commit 0ad351e
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ private static IEnumerable<TimeRangePatch> PrepareForTimePeriodChainConstructor(
}

var result = timeperiods.OrderBy(tp => tp.Start);
var ambigousStarts = result.GroupBy(tp => tp.To).Where(g => g.Count() > 1).Select(g => g.Select(x => x.Start).Distinct());
var ambigousEnds = result.GroupBy(tp => tp.End).Where(g => g.Count() > 1).Select(g => g.Select(x => x.End).Distinct()); ;
var ambigousStarts = result.GroupBy(tp => tp.Start).Where(g => g.Count() > 1).Select(g => g.Select(x => x.Start.ToString("o")).First()).Distinct();
var ambigousEnds = result.GroupBy(tp => tp.End).Where(g => g.Count() > 1).Select(g => g.Select(x => x.End.ToString("o")).First()).Distinct(); ;
bool baseConstructorIsLikelyToCrash = ambigousStarts.Any() || ambigousEnds.Any();
if (baseConstructorIsLikelyToCrash)
{
Expand All @@ -88,7 +88,7 @@ private static IEnumerable<TimeRangePatch> PrepareForTimePeriodChainConstructor(
catch (InvalidOperationException invalidOpException) when (invalidOpException.Message.EndsWith("out of range"))
{
// if it would crash and we do know the reasons, then we throw a more meaningful exception here instead of waiting for the base class to crash
throw new ArgumentException($"The given periods contain ambiguous starts ({ambigousStarts}) or ends ({ambigousEnds})", innerException: invalidOpException);
throw new ArgumentException($"The given periods contain ambiguous starts ({string.Join(", ", ambigousStarts)}) or ends ({string.Join(", ", ambigousEnds)})", innerException: invalidOpException);
}
}
return result;
Expand Down

0 comments on commit 0ad351e

Please sign in to comment.