Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Fix string concatenation #57

Merged
merged 1 commit into from
Oct 4, 2023
Merged

🐛Fix string concatenation #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ChronoJsonDiffPatch/ChronoJsonDiffPatch/TimeRangePatchChain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ private static IEnumerable<TimeRangePatch> PrepareForTimePeriodChainConstructor(
}

var result = timeperiods.OrderBy(tp => tp.Start);
var ambigousStarts = result.GroupBy(tp => tp.To).Where(g => g.Count() > 1).Select(g => g.Select(x => x.Start).Distinct());
var ambigousEnds = result.GroupBy(tp => tp.End).Where(g => g.Count() > 1).Select(g => g.Select(x => x.End).Distinct()); ;
var ambigousStarts = result.GroupBy(tp => tp.Start).Where(g => g.Count() > 1).Select(g => g.Select(x => x.Start.ToString("o")).First()).Distinct();
var ambigousEnds = result.GroupBy(tp => tp.End).Where(g => g.Count() > 1).Select(g => g.Select(x => x.End.ToString("o")).First()).Distinct(); ;
bool baseConstructorIsLikelyToCrash = ambigousStarts.Any() || ambigousEnds.Any();
if (baseConstructorIsLikelyToCrash)
{
Expand All @@ -88,7 +88,7 @@ private static IEnumerable<TimeRangePatch> PrepareForTimePeriodChainConstructor(
catch (InvalidOperationException invalidOpException) when (invalidOpException.Message.EndsWith("out of range"))
{
// if it would crash and we do know the reasons, then we throw a more meaningful exception here instead of waiting for the base class to crash
throw new ArgumentException($"The given periods contain ambiguous starts ({ambigousStarts}) or ends ({ambigousEnds})", innerException: invalidOpException);
throw new ArgumentException($"The given periods contain ambiguous starts ({string.Join(", ", ambigousStarts)}) or ends ({string.Join(", ", ambigousEnds)})", innerException: invalidOpException);
}
}
return result;
Expand Down
Loading