Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Readout full EBD names from metadata #103

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

OLILHR
Copy link
Member

@OLILHR OLILHR commented Nov 5, 2024

  • full names are searchable
  • too long names are scrollable sideways
  • by default, selectable EBDs in the list = only ebd_code like "E_0000"
  • if ebd_name is not empty in metadata, the extended ebd_code + ebd_name is shown instead

example (ebd_name are not part of the metadata yet; hence Netzzugangsthemen are used instead):

Screenshot 2024-11-04 at 21 55 01

requires Hochfrequenz/ebdamame#246 before merging

@OLILHR OLILHR linked an issue Nov 5, 2024 that may be closed by this pull request
@OLILHR
Copy link
Member Author

OLILHR commented Nov 5, 2024

to do: change chapter to ebd_name once its provided in the metadata

try {
        const jsonPath = join(versionPath, `${ebdCode}.json`);
        const parseMetaData = JSON.parse(
          readFileSync(jsonPath, "utf-8"),
        ) as MetaData;
        if (parseMetaData.metadata.chapter?.trim()) {
          ebd_name = `${ebdCode}_${parseMetaData.metadata.chapter}`;
        }

Copy link

github-actions bot commented Nov 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-water-047c71203-103.westeurope.5.azurestaticapps.net

@Hochfrequenz Hochfrequenz deleted a comment from github-actions bot Nov 5, 2024
@OLILHR OLILHR marked this pull request as ready for review November 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Add EBD names provided by json meta data
1 participant