calibrite-profiler 1.3.3

[MTCoster]

Also add a comment to the cask to explain the original intent and prevent the same mistaken change from being made again.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

---

Depends on Homebrew/brew#18488; there's no way currently to describe an exception as "prerelease or stable is fine" in github_prerelease_allowlist.json.

[samford]

The first-party download page links to the newest release on GitHub, so we can check that without having to worry about the pre-release issue. It's currently pointing to 1.3.3 despite it being "pre-release" on GitHub (as expected). I pushed a commit to update the livecheck block accordingly.

I converted this to a draft until the related brew PR is done, so this won't get merged prematurely.

[MTCoster]

The first-party download page links to the newest release on GitHub, so we can check that without having to worry about the pre-release issue. It's currently pointing to 1.3.3 despite it being "pre-release" on GitHub (as expected). I pushed a commit to update the livecheck block accordingly.

That works too! You can go ahead and rewrite history here to replace my original revert commit with yours if you like.

With this change I guess we no longer depend on Homebrew/brew#18488, but there's a separate discussion going on over there anyway so they can be independent now.

[samford]

I'm not very knowledgeable about the prerelease allowlist behavior for casks but I updated this to use all, as that may allow us to move this forward in the interim time.

This works but our cask maintainers will have to confirm whether this is the appropriate way to handle this particular situation (i.e., allowing versions that are "pre-release" on GitHub, as we're tracking the first-party download page in the livecheck block and presumably upstream won't update it to link to an unstable version). Alternatively, we can use a specific version (1.3.3) but this would require us to update the version in the allowlist with almost every release.

Normally I would say that we should ask upstream to not mark stable releases as "pre-release" if they're advertised as stable on the first-party download page but they haven't ever responded to issues in the GitHub repository, so it may not be worth the effort.

[MTCoster]

I'm not very knowledgeable about the prerelease allowlist behavior for casks but I updated this to use all, [...]

Is the exception actually needed? From what I understand, it's only used for :github_* livechecks.

[samford]

Is the exception actually needed? From what I understand, it's only used for :github_* livechecks.

Yes, formulae/casks using a GitHub tag/release in the url are audited to make sure that the release isn't marked as "pre-release" on GitHub (the modified code in the brew PR relates to the audit). github_prerelease_allowlist.json is used to add an exception to avoid this audit failure. Without that addition, brew audit will fail with v1.3.3 is a GitHub pre-release. [You can test this locally by removing the added line from the allowlist file and running brew audit --strict --online calibrite-profiler.]

That audit doesn't interact with livecheck blocks (i.e., the livecheck block URL/strategy isn't a factor) and it's just a coincidence that formulae/casks using a GitHub release asset often use the GithubLatest/GithubReleases strategies to identify versions.

[p-linnane]

Makes sense to me. Thanks!