Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make virt-manager use Python 3.13 (+dependencies) #193553

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make virt-manager use Python 3.13 (+dependencies) #193553

wants to merge 3 commits into from
+32 −21

Conversation

unshare
Copy link
Contributor

@unshare unshare commented Oct 10, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 10, 2024
chenrui333
chenrui333 reviewed Oct 10, 2024
View reviewed changes
Formula/lib/libvirt-python.rb
# language=Python
<<~EOS
import libvirt
pythons.each do |python|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need pythons in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it's a good idea to compute the list of Pythons instead of coding the same versions in two or more places.

chenrui333
chenrui333 reviewed Oct 10, 2024
View reviewed changes
Formula/v/virt-manager.rb
python3 = "python3.12"
venv = virtualenv_create(libexec, python3)
venv.pip_install resources
pythons.each do |python|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
python Python use is a significant feature of the PR or issue python-3.13-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unshare @chenrui333