Fix: Missing defaultMeta in log entry while using Profiler

fixes winstonjs#1665
HonzaMac · Jun 17, 2021 · 584111e · 584111e
1 parent 2625f60
commit 584111e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/lib/winston/profiler.js b/lib/winston/profiler.js
@@ -45,7 +45,15 @@ module.exports = class Profiler {
     const info = typeof args[args.length - 1] === 'object' ? args.pop() : {};
     info.level = info.level || 'info';
     info.durationMs = (Date.now()) - this.start;
+    this._addDefaultMeta(info);
 
     return this.logger.write(info);
   }
+
+  _addDefaultMeta(msg) {
+    if (this.logger.defaultMeta) {
+      Object.assign(msg, this.logger.defaultMeta);
+    }
+  }
+
 };
diff --git a/test/helpers/index.js b/test/helpers/index.js
@@ -25,9 +25,10 @@ var helpers = exports;
  * @param {function} write Write function for the specified stream
  * @returns {Logger} A winston.Logger instance
  */
-helpers.createLogger = function (write, format) {
+helpers.createLogger = function (write, format, defaultMeta) {
   return winston.createLogger({
     format,
+    defaultMeta,
     transports: [
       mockTransport.createMockTransport(write)
     ]

diff --git a/test/logger.test.js b/test/logger.test.js
@@ -905,9 +905,10 @@ describe('Logger (profile, startTimer)', function (done) {
       assume(info.level).equals('info');
       assume(info.durationMs).is.a('number');
       assume(info.message).equals('testing1');
+      assume(info.service).equals('your-service-name');
       assume(info[MESSAGE]).is.a('string');
       done();
-    });
+    }, null, { service: 'your-service-name' });
 
     var timer = logger.startTimer();
     setTimeout(function () {