Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint issue #1

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Fix eslint issue #1

merged 4 commits into from
Aug 22, 2023

Conversation

HossainAraf
Copy link
Owner

Methods implemented;

  • Create a feature branch for the following changes;
  • Install node.js;
  • Create a React application.

Copy link

@skyv26 skyv26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HossainAraf,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

STATUS: APPROVED 🟢

Highlights

  • Good PR title ✅
  • Descriptive PR description ✅
  • Implement the features ✅
  • Professional README template ✅
  • Linters are green ✅
  • Correct Gitflow workflow ✅
  • Meaningful Github commits ✅
  • Correct .github/workflows for linters ✅
  • Well-structured project ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

⚠️ WARNING ⚠️

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms

@skyv26 linkedin-skyv2022 @vrma_aakash @skybrel @skybrel

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@HossainAraf HossainAraf merged commit 45f1e38 into dev Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants