Math magicians: Events #3
Conversation
There was a problem hiding this comment.
Hi @HossainAraf,
Required Changes ♻️
Good job so far!
You are doing it well 👏🏽 there are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No linter errors ✔️
- Descriptive PR ✔️
- Correct Git flow ✔️
- Handle events in a React app. ✔️
- Use React life cycle methods. ✔️
- Use React state. ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <Button label="AC" onClick={() => handleButtonClick('AC')} /> | ||
| <Button label="+/-" onClick={() => handleButtonClick('+/-')} /> | ||
| <Button label="%" onClick={() => handleButtonClick('%')} /> | ||
| <Button className="operator-right-column" label="÷" onClick={() => handleButtonClick('÷')} /> | ||
| <Button label="7" onClick={() => handleButtonClick('7')} /> | ||
| <Button label="8" onClick={() => handleButtonClick('8')} /> | ||
| <Button label="9" onClick={() => handleButtonClick('9')} /> | ||
| <Button className="operator-right-column" label="x" onClick={() => handleButtonClick('x')} /> | ||
| <Button label="4" onClick={() => handleButtonClick('4')} /> | ||
| <Button label="5" onClick={() => handleButtonClick('5')} /> | ||
| <Button label="6" onClick={() => handleButtonClick('6')} /> | ||
| <Button className="operator-right-column" label="-" onClick={() => handleButtonClick('-')} /> | ||
| <Button label="1" onClick={() => handleButtonClick('1')} /> | ||
| <Button label="2" onClick={() => handleButtonClick('2')} /> | ||
| <Button label="3" onClick={() => handleButtonClick('3')} /> | ||
| <Button className="operator-right-column" label="+" onClick={() => handleButtonClick('+')} /> | ||
| <Button className="zero-btn" label="0" onClick={() => handleButtonClick('0')} /> | ||
| <Button label="." onClick={() => handleButtonClick('.')} /> | ||
| <Button className="operator-right-column" label="=" onClick={() => handleButtonClick('=')} /> | ||
|
|
There was a problem hiding this comment.
- When I click on any operator button a second file of numbers arises, please 🙏🏽 fix this issue to be similar to a basic calculator, it is there should be one line of numbers always for a better UX.
There was a problem hiding this comment.
🟢 Approved! 🥳
Hi @HossainAraf 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights 🌟
- ✔️ Descriptions are very descriptive
- ✔️ App is running smoothly as it should
Optional suggestions 🤷♂️
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Important Notes 📝
- Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
- Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Methods Implemented: