Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc_chunk updates and new parameters #591

Merged
merged 2 commits into from
Sep 16, 2024
Merged

doc_chunk updates and new parameters #591

merged 2 commits into from
Sep 16, 2024

Conversation

dolfim-ibm
Copy link
Member

Why are these changes needed?

Updating doc_chunk for

  1. Use the upstream docling-core library
  2. Expose the min_chunk_len parameter. Also see issue Refs [Bug] chunking fails on PDFs with one line text #590

Related issue number (if any).

Refs #590

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Copy link
Member

@daw3rd daw3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're adding a paramaeter, I think you need to update the kfp_ray files.

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Copy link
Member

@daw3rd daw3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daw3rd daw3rd merged commit 59de9e3 into dev Sep 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants