Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docling to 1.20.0 #723

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Update Docling to 1.20.0 #723

merged 3 commits into from
Oct 18, 2024

Conversation

dolfim-ibm
Copy link
Member

@dolfim-ibm dolfim-ibm commented Oct 18, 2024

Why are these changes needed?

The Docling updates allow (among others)

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@touma-I
Copy link
Collaborator

touma-I commented Oct 18, 2024

Thanks @dolfim-ibm . Any ideas where the error comes from? cc; @daw3rd In case he had seen this before.

Full diff:
  - <pyarrow.lib.ChunkedArray object at 0x7f010d07a070>
  ?                                            -------
  + <pyarrow.lib.ChunkedArray object at 0x7f00fcc64d10>
  ?                                          +++++++
    [
      [
  -     "#/main-text/1"
  ?      ^^         ^
  +     "$.main-text[1]"
  ?      ^^         ^ +
      ]
    ]
============================== 1 failed in 19.80s ==============================
make[2]: *** [../../../../.make.defaults:411: .defaults.test-src] Error 1
make[2]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/doc_chunk/ray'
make[1]: *** [../../../.make.defaults:125: .recurse] Error 2
make[1]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/doc_chunk'
make: *** [Makefile:42: test-src] Error 2
make: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/doc_chunk'
Error: Process completed with exit code 2.

@dolfim-ibm
Copy link
Member Author

Thanks @dolfim-ibm . Any ideas where the error comes from? cc; @daw3rd In case he had seen this before.

it is known, fixing it.

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Copy link
Member

@daw3rd daw3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@touma-I touma-I merged commit c56f016 into dev Oct 18, 2024
13 checks passed
@shahrokhDaijavad
Copy link
Member

@sujee If you want to test if @dolfim-ibm's latest version of docling (1.20.0) works on a notebook that uses pdf2parquet on a Windows machine as part of your RAG example (assuming you have access to a native Windows machine!), you can try:
pip install --extra-index-url https://testpypi.python.org/pypi 'data-prep-toolkit-transforms[pdf2parquet]==0.2.2.dev1'
this version of docling is not in pypi's 0.2.2.dev1 and will be in the next release on pypi.
cc: @touma-I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants