Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating RAG example to use IBM granite model #745

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sujee
Copy link
Contributor

@sujee sujee commented Oct 25, 2024

Why are these changes needed?

Updating RAG example to use IBM Granite 3.0 model

Related issue number (if any).

Signed-off-by: Sujee Maniyam <sujee@node51.com>
@shahrokhDaijavad
Copy link
Member

@sujee I am getting an error while running the ray version of the Notebook (rag_1A_dpk_process_ray.ipynb) about not finding pdf2parquet_transform_ray. I had no problem with the Python version of this notebook. Here is the error:

ModuleNotFoundError Traceback (most recent call last)
File :13

ModuleNotFoundError: No module named 'pdf2parquet_transform_ray'

@shahrokhDaijavad
Copy link
Member

@sujee One more thing: In rag_1D_query_replicate.ipynb file, in "Step-6: Initialize LLM", please add the choice of IBM Granite as one of the models in the comments (I know that you are picking the Granite model for the actual execution).

@sujee
Copy link
Contributor Author

sujee commented Oct 25, 2024

@sujee I am getting an error while running the ray version of the Notebook (rag_1A_dpk_process_ray.ipynb) about not finding pdf2parquet_transform_ray. I had no problem with the Python version of this notebook. Here is the error:

ModuleNotFoundError Traceback (most recent call last) File :13

ModuleNotFoundError: No module named 'pdf2parquet_transform_ray'

If you have created a custom kernel when you setup the python env, like this

python -m ipykernel install --user --name=data-prep-kit --display-name "dataprepkit"

Choose this kernel in jupyter when running this notebook. See if it fixes the error.

@shahrokhDaijavad
Copy link
Member

@sujee Thanks for the suggestion. I was using a conda env. So, I removed that env and created and activated a new env. That fixed the problem! In any case, since I have now tested successfully by going all the way through the rag_1D notebook by starting from either Python or Ray versions, I am ready to approve this, after you make the "one more thing" change above. Thanks.

Signed-off-by: Sujee Maniyam <sujee@node51.com>
Copy link
Member

@shahrokhDaijavad shahrokhDaijavad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @sujee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants