Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scanner link in portal view and "Ingress" tab in mobile share portal view #652

Merged

Conversation

xscreach
Copy link
Contributor

@xscreach xscreach commented Jul 25, 2023

Fixes #563 by adding:

  • Browser version - "Copy scanner link" next to "Portal link" in info panel
    image
  • Mobile version - "Ingress" tab in "Share portal" view
    SmartSelect_20230725_031240_IITC Mobile Test.jpg

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk fe8a1d1
test-0.36.0.20230726.105825.zip fe8a1d1

See build on website

@xscreach xscreach force-pushed the feature/Add-share-link-in-portal-view branch from 17eabc4 to 1abd141 Compare July 25, 2023 10:51
@modos189
Copy link
Contributor

In the desktop version, clicking on the link redirects and opens the same page. It is not obvious that the link should be copied. I suggest in the desktop version to copy the link to the clipboard. As it is implemented here: https://raw.githubusercontent.com/IITC-CE/Community-plugins/master/dist/xMAXIMx/scanner-link-copy.user.js

@modos189 modos189 merged commit 1c0d085 into IITC-CE:master Jul 28, 2023
2 checks passed
@modos189 modos189 deleted the feature/Add-share-link-in-portal-view branch July 28, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add share link in portal view
2 participants